Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

power: supply: Use IRQF_ONESHOT

Fixes coccicheck error:

drivers/power/supply/pm2301_charger.c:1089:7-27: ERROR:
drivers/power/supply/lp8788-charger.c:502:8-28: ERROR:
drivers/power/supply/tps65217_charger.c:239:8-33: ERROR:
drivers/power/supply/tps65090-charger.c:303:8-33: ERROR:

Threaded IRQ with no primary handler requested without IRQF_ONESHOT

Signed-off-by: dongjian <dongjian@yulong.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

authored by

dongjian and committed by
Sebastian Reichel
2469b836 4eed7f5a

+4 -4
+1 -1
drivers/power/supply/lp8788-charger.c
··· 501 501 502 502 ret = request_threaded_irq(virq, NULL, 503 503 lp8788_charger_irq_thread, 504 - 0, name, pchg); 504 + IRQF_ONESHOT, name, pchg); 505 505 if (ret) 506 506 break; 507 507 }
+1 -1
drivers/power/supply/pm2301_charger.c
··· 1089 1089 ret = request_threaded_irq(gpio_to_irq(pm2->pdata->gpio_irq_number), 1090 1090 NULL, 1091 1091 pm2xxx_charger_irq[0].isr, 1092 - pm2->pdata->irq_type, 1092 + pm2->pdata->irq_type | IRQF_ONESHOT, 1093 1093 pm2xxx_charger_irq[0].name, pm2); 1094 1094 1095 1095 if (ret != 0) {
+1 -1
drivers/power/supply/tps65090-charger.c
··· 301 301 302 302 if (irq != -ENXIO) { 303 303 ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, 304 - tps65090_charger_isr, 0, "tps65090-charger", cdata); 304 + tps65090_charger_isr, IRQF_ONESHOT, "tps65090-charger", cdata); 305 305 if (ret) { 306 306 dev_err(cdata->dev, 307 307 "Unable to register irq %d err %d\n", irq,
+1 -1
drivers/power/supply/tps65217_charger.c
··· 238 238 for (i = 0; i < NUM_CHARGER_IRQS; i++) { 239 239 ret = devm_request_threaded_irq(&pdev->dev, irq[i], NULL, 240 240 tps65217_charger_irq, 241 - 0, "tps65217-charger", 241 + IRQF_ONESHOT, "tps65217-charger", 242 242 charger); 243 243 if (ret) { 244 244 dev_err(charger->dev,