Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

usb: typec: tcpci: clear the fault status bit

According the "USB Type-C Port Controller Interface Specification v2.0"
the TCPC sets the fault status register bit-7
(AllRegistersResetToDefault) once the registers have been reset to
their default values.

This triggers an alert(-irq) on PTN5110 devices albeit we do mask the
fault-irq, which may cause a kernel hang. Fix this generically by writing
a one to the corresponding bit-7.

Cc: stable@vger.kernel.org
Fixes: 74e656d6b055 ("staging: typec: Type-C Port Controller Interface driver (tcpci)")
Reported-by: "Angus Ainslie (Purism)" <angus@akkea.ca>
Closes: https://lore.kernel.org/all/20190508002749.14816-2-angus@akkea.ca/
Reported-by: Christian Bach <christian.bach@scs.ch>
Closes: https://lore.kernel.org/regressions/ZR0P278MB07737E5F1D48632897D51AC3EB329@ZR0P278MB0773.CHEP278.PROD.OUTLOOK.COM/t/
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20230816172502.1155079-1-festevam@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Marco Felsch and committed by
Greg Kroah-Hartman
23e60c8d f2364330

+5
+4
drivers/usb/typec/tcpm/tcpci.c
··· 602 602 if (time_after(jiffies, timeout)) 603 603 return -ETIMEDOUT; 604 604 605 + ret = tcpci_write16(tcpci, TCPC_FAULT_STATUS, TCPC_FAULT_STATUS_ALL_REG_RST_TO_DEFAULT); 606 + if (ret < 0) 607 + return ret; 608 + 605 609 /* Handle vendor init */ 606 610 if (tcpci->data->init) { 607 611 ret = tcpci->data->init(tcpci, tcpci->data);
+1
include/linux/usb/tcpci.h
··· 103 103 #define TCPC_POWER_STATUS_SINKING_VBUS BIT(0) 104 104 105 105 #define TCPC_FAULT_STATUS 0x1f 106 + #define TCPC_FAULT_STATUS_ALL_REG_RST_TO_DEFAULT BIT(7) 106 107 107 108 #define TCPC_ALERT_EXTENDED 0x21 108 109