Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Staging: iio/dac/ad5064.c: signedness bug in ad5064_read_raw()

regulator_get_voltage() returns an int so "scale_uv" should be an
int. Making it unsigned here breaks the error handling.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

authored by

Dan Carpenter and committed by
Greg Kroah-Hartman
23a3b8cc c8a9f805

+1 -1
+1 -1
drivers/staging/iio/dac/ad5064.c
··· 280 280 long m) 281 281 { 282 282 struct ad5064_state *st = iio_priv(indio_dev); 283 - unsigned long scale_uv; 284 283 unsigned int vref; 284 + int scale_uv; 285 285 286 286 switch (m) { 287 287 case 0: