Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

selftests: kmod: test disabling module autoloading

Test that request_module() fails with -ENOENT when
/proc/sys/kernel/modprobe contains (a) a nonexistent path, and (b) an
empty path.

Case (b) is a regression test for the patch "kmod: make request_module()
return an error when autoloading is disabled".

Tested with 'kmod.sh -t 0010 && kmod.sh -t 0011', and also simply with
'kmod.sh' to run all kmod tests.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jeff Vander Stoep <jeffv@google.com>
Cc: Jessica Yu <jeyu@kernel.org>
Cc: Kees Cook <keescook@chromium.org>
Cc: NeilBrown <neilb@suse.com>
Link: http://lkml.kernel.org/r/20200312202552.241885-5-ebiggers@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Eric Biggers and committed by
Linus Torvalds
23756e55 6d573a07

+30
+30
tools/testing/selftests/kmod/kmod.sh
··· 61 61 ALL_TESTS="$ALL_TESTS 0007:5:1" 62 62 ALL_TESTS="$ALL_TESTS 0008:150:1" 63 63 ALL_TESTS="$ALL_TESTS 0009:150:1" 64 + ALL_TESTS="$ALL_TESTS 0010:1:1" 65 + ALL_TESTS="$ALL_TESTS 0011:1:1" 64 66 65 67 # Kselftest framework requirement - SKIP code is 4. 66 68 ksft_skip=4 ··· 151 149 152 150 test_finish() 153 151 { 152 + echo "$MODPROBE" > /proc/sys/kernel/modprobe 154 153 echo "Test completed" 155 154 } 156 155 ··· 446 443 config_expect_result ${FUNCNAME[0]} SUCCESS 447 444 } 448 445 446 + kmod_test_0010() 447 + { 448 + kmod_defaults_driver 449 + config_num_threads 1 450 + echo "/KMOD_TEST_NONEXISTENT" > /proc/sys/kernel/modprobe 451 + config_trigger ${FUNCNAME[0]} 452 + config_expect_result ${FUNCNAME[0]} -ENOENT 453 + echo "$MODPROBE" > /proc/sys/kernel/modprobe 454 + } 455 + 456 + kmod_test_0011() 457 + { 458 + kmod_defaults_driver 459 + config_num_threads 1 460 + # This causes the kernel to not even try executing modprobe. The error 461 + # code is still -ENOENT like when modprobe doesn't exist, so we can't 462 + # easily test for the exact difference. But this still is a useful test 463 + # since there was a bug where request_module() returned 0 in this case. 464 + echo > /proc/sys/kernel/modprobe 465 + config_trigger ${FUNCNAME[0]} 466 + config_expect_result ${FUNCNAME[0]} -ENOENT 467 + echo "$MODPROBE" > /proc/sys/kernel/modprobe 468 + } 469 + 449 470 list_tests() 450 471 { 451 472 echo "Test ID list:" ··· 487 460 echo "0007 x $(get_test_count 0007) - multithreaded tests with default setup test request_module() and get_fs_type()" 488 461 echo "0008 x $(get_test_count 0008) - multithreaded - push kmod_concurrent over max_modprobes for request_module()" 489 462 echo "0009 x $(get_test_count 0009) - multithreaded - push kmod_concurrent over max_modprobes for get_fs_type()" 463 + echo "0010 x $(get_test_count 0010) - test nonexistent modprobe path" 464 + echo "0011 x $(get_test_count 0011) - test completely disabling module autoloading" 490 465 } 491 466 492 467 usage() ··· 645 616 allow_user_defaults 646 617 load_req_mod 647 618 619 + MODPROBE=$(</proc/sys/kernel/modprobe) 648 620 trap "test_finish" EXIT 649 621 650 622 parse_args $@