* git://github.com/rustyrussell/linux: params: make dashes and underscores in parameter names truly equal kmod: prevent kmod_loop_msg overflow in __request_module()
···262262 .str = &__param_string_##name, 0, perm); \263263 __MODULE_PARM_TYPE(name, "string")264264265265+/**266266+ * parameq - checks if two parameter names match267267+ * @name1: parameter name 1268268+ * @name2: parameter name 2269269+ *270270+ * Returns true if the two parameter names are equal.271271+ * Dashes (-) are considered equal to underscores (_).272272+ */273273+extern bool parameq(const char *name1, const char *name2);274274+275275+/**276276+ * parameqn - checks if two parameter names match277277+ * @name1: parameter name 1278278+ * @name2: parameter name 2279279+ * @n: the length to compare280280+ *281281+ * Similar to parameq(), except it compares @n characters.282282+ */283283+extern bool parameqn(const char *name1, const char *name2, size_t n);284284+265285/* Called on module insert or kernel boot */266286extern int parse_args(const char *name,267287 char *args,
+2-2
init/main.c
···163163 p = __setup_start;164164 do {165165 int n = strlen(p->str);166166- if (!strncmp(line, p->str, n)) {166166+ if (parameqn(line, p->str, n)) {167167 if (p->early) {168168 /* Already done in parse_early_param?169169 * (Needs exact match on param part).···392392 const struct obs_kernel_param *p;393393394394 for (p = __setup_start; p < __setup_end; p++) {395395- if ((p->early && strcmp(param, p->str) == 0) ||395395+ if ((p->early && parameq(param, p->str)) ||396396 (strcmp(param, "console") == 0 &&397397 strcmp(p->str, "earlycon") == 0)398398 ) {
+3-1
kernel/kmod.c
···114114 atomic_inc(&kmod_concurrent);115115 if (atomic_read(&kmod_concurrent) > max_modprobes) {116116 /* We may be blaming an innocent here, but unlikely */117117- if (kmod_loop_msg++ < 5)117117+ if (kmod_loop_msg < 5) {118118 printk(KERN_ERR119119 "request_module: runaway loop modprobe %s\n",120120 module_name);121121+ kmod_loop_msg++;122122+ }121123 atomic_dec(&kmod_concurrent);122124 return -ENOMEM;123125 }
+14-7
kernel/params.c
···6767 }6868}69697070-static inline char dash2underscore(char c)7070+static char dash2underscore(char c)7171{7272 if (c == '-')7373 return '_';7474 return c;7575}76767777-static inline int parameq(const char *input, const char *paramname)7777+bool parameqn(const char *a, const char *b, size_t n)7878{7979- unsigned int i;8080- for (i = 0; dash2underscore(input[i]) == paramname[i]; i++)8181- if (input[i] == '\0')8282- return 1;8383- return 0;7979+ size_t i;8080+8181+ for (i = 0; i < n; i++) {8282+ if (dash2underscore(a[i]) != dash2underscore(b[i]))8383+ return false;8484+ }8585+ return true;8686+}8787+8888+bool parameq(const char *a, const char *b)8989+{9090+ return parameqn(a, b, strlen(a)+1);8491}85928693static int parse_one(char *param,