tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

ALSA: cmi8328: Use safer strscpy() instead of strcpy()

Use a safer function strscpy() instead of strcpy() for copying to
arrays.

Only idiomatic code replacement, and no functional changes.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20250710100727.22653-26-tiwai@suse.de

Takashi Iwai 231d1350 dd9de1a1

+10 -10
+10 -10
sound/isa/cmi8328.c
··· 155 155 memset(&id2, 0, sizeof(id2)); 156 156 id1.iface = id2.iface = SNDRV_CTL_ELEM_IFACE_MIXER; 157 157 /* rename AUX0 switch to CD */ 158 - strcpy(id1.name, "Aux Playback Switch"); 159 - strcpy(id2.name, "CD Playback Switch"); 158 + strscpy(id1.name, "Aux Playback Switch"); 159 + strscpy(id2.name, "CD Playback Switch"); 160 160 err = snd_ctl_rename_id(card, &id1, &id2); 161 161 if (err < 0) { 162 162 dev_err(card->dev, "error renaming control\n"); 163 163 return err; 164 164 } 165 165 /* rename AUX0 volume to CD */ 166 - strcpy(id1.name, "Aux Playback Volume"); 167 - strcpy(id2.name, "CD Playback Volume"); 166 + strscpy(id1.name, "Aux Playback Volume"); 167 + strscpy(id2.name, "CD Playback Volume"); 168 168 err = snd_ctl_rename_id(card, &id1, &id2); 169 169 if (err < 0) { 170 170 dev_err(card->dev, "error renaming control\n"); 171 171 return err; 172 172 } 173 173 /* rename AUX1 switch to Synth */ 174 - strcpy(id1.name, "Aux Playback Switch"); 174 + strscpy(id1.name, "Aux Playback Switch"); 175 175 id1.index = 1; 176 - strcpy(id2.name, "Synth Playback Switch"); 176 + strscpy(id2.name, "Synth Playback Switch"); 177 177 err = snd_ctl_rename_id(card, &id1, &id2); 178 178 if (err < 0) { 179 179 dev_err(card->dev, "error renaming control\n"); 180 180 return err; 181 181 } 182 182 /* rename AUX1 volume to Synth */ 183 - strcpy(id1.name, "Aux Playback Volume"); 183 + strscpy(id1.name, "Aux Playback Volume"); 184 184 id1.index = 1; 185 - strcpy(id2.name, "Synth Playback Volume"); 185 + strscpy(id2.name, "Synth Playback Volume"); 186 186 err = snd_ctl_rename_id(card, &id1, &id2); 187 187 if (err < 0) { 188 188 dev_err(card->dev, "error renaming control\n"); ··· 362 362 if (snd_opl3_hwdep_new(opl3, 0, 1, NULL) < 0) 363 363 dev_warn(pdev, "error initializing OPL3 hwdep\n"); 364 364 365 - strcpy(card->driver, "CMI8328"); 366 - strcpy(card->shortname, "C-Media CMI8328"); 365 + strscpy(card->driver, "CMI8328"); 366 + strscpy(card->shortname, "C-Media CMI8328"); 367 367 sprintf(card->longname, "%s at 0x%lx, irq %d, dma %d,%d", 368 368 card->shortname, cmi->wss->port, irq[ndev], dma1[ndev], 369 369 (dma2[ndev] >= 0) ? dma2[ndev] : dma1[ndev]);