Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

PCI: exynos: Correct generic PHY usage

The proper initialization for generic PHYs is to call first phy_init(),
then phy_power_on().

While touching this, remove the phy_reset() call. It is just a left-over
from the obsoleted Exynos5440 support and the current exynos-pcie PHY
driver doesn't even support this function. It is also rarely used by other
drivers.

Link: https://lore.kernel.org/r/20220628220409.26545-2-m.szyprowski@samsung.com
Reported-by: Bjorn Helgaas <helgaas@kernel.org>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Chanho Park <chanho61.park@samsung.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

authored by

Marek Szyprowski and committed by
Bjorn Helgaas
22f3571c f2812227

+1 -2
+1 -2
drivers/pci/controller/dwc/pci-exynos.c
··· 258 258 259 259 exynos_pcie_assert_core_reset(ep); 260 260 261 - phy_reset(ep->phy); 262 - phy_power_on(ep->phy); 263 261 phy_init(ep->phy); 262 + phy_power_on(ep->phy); 264 263 265 264 exynos_pcie_deassert_core_reset(ep); 266 265 exynos_pcie_enable_irq_pulse(ep);