Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[media] tc358743: add missing Kconfig dependency/select

As reported by Randy:
> when CONFIG_MEDIA_CONTROLLER is not enabled:
>
> ../drivers/media/i2c/tc358743.c: In function 'tc358743_probe':
> ../drivers/media/i2c/tc358743.c:1890:29: error: 'struct v4l2_subdev' has no member named 'entity'
> err = media_entity_init(&sd->entity, 1, &state->pad, 0);
> ^
> ../drivers/media/i2c/tc358743.c:1940:26: error: 'struct v4l2_subdev' has no member named 'entity'
> media_entity_cleanup(&sd->entity);
> ^
> ../drivers/media/i2c/tc358743.c: In function 'tc358743_remove':
> ../drivers/media/i2c/tc358743.c:1955:26: error: 'struct v4l2_subdev' has no member named 'entity'
> media_entity_cleanup(&sd->entity);
> ^

This driver depends on VIDEO_V4L2_SUBDEV_API and needs to select HDMI.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

authored by

Hans Verkuil and committed by
Mauro Carvalho Chehab
22dbe35a 62e5f051

+2 -1
+2 -1
drivers/media/i2c/Kconfig
··· 289 289 290 290 config VIDEO_TC358743 291 291 tristate "Toshiba TC358743 decoder" 292 - depends on VIDEO_V4L2 && I2C 292 + depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API 293 + select HDMI 293 294 ---help--- 294 295 Support for the Toshiba TC358743 HDMI to MIPI CSI-2 bridge. 295 296