tjh.dev
Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
net: mii: make mii_ethtool_gset() return void
mii_ethtool_gset() does not return any errors. Since there are no users
of this function that rely on its return value, it can be
made void.
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
authored by
Pavel Skripkin
and committed by
David S. Miller
2274af1d
9fcfd088
+2
-6
+1
-5
drivers/net/mii.c
+1
-5
drivers/net/mii.c
···
49
49
*
50
50
* The @ecmd parameter is expected to have been cleared before calling
51
51
* mii_ethtool_gset().
52
-
*
53
-
* Returns 0 for success, negative on error.
54
52
*/
55
-
int mii_ethtool_gset(struct mii_if_info *mii, struct ethtool_cmd *ecmd)
53
+
void mii_ethtool_gset(struct mii_if_info *mii, struct ethtool_cmd *ecmd)
56
54
{
57
55
struct net_device *dev = mii->dev;
58
56
u16 bmcr, bmsr, ctrl1000 = 0, stat1000 = 0;
···
129
131
mii->full_duplex = ecmd->duplex;
130
132
131
133
/* ignore maxtxpkt, maxrxpkt for now */
132
-
133
-
return 0;
134
134
}
135
135
136
136
/**
+1
-1
include/linux/mii.h
+1
-1
include/linux/mii.h
···
32
32
33
33
extern int mii_link_ok (struct mii_if_info *mii);
34
34
extern int mii_nway_restart (struct mii_if_info *mii);
35
-
extern int mii_ethtool_gset(struct mii_if_info *mii, struct ethtool_cmd *ecmd);
35
+
extern void mii_ethtool_gset(struct mii_if_info *mii, struct ethtool_cmd *ecmd);
36
36
extern void mii_ethtool_get_link_ksettings(
37
37
struct mii_if_info *mii, struct ethtool_link_ksettings *cmd);
38
38
extern int mii_ethtool_sset(struct mii_if_info *mii, struct ethtool_cmd *ecmd);