Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

pinctrl: samsung: Fix missing OF and GPIOLIB dependency on S3C24xx and S3C64xx

All Samsung pinctrl drivers select common part - PINCTRL_SAMSUNG which uses
both OF and GPIOLIB inside. However only Exynos drivers depend on these,
therefore after enabling COMPILE_TEST, on x86_64 build of S3C64xx driver
failed:

drivers/pinctrl/samsung/pinctrl-samsung.c: In function ‘samsung_gpiolib_register’:
drivers/pinctrl/samsung/pinctrl-samsung.c:969:5: error: ‘struct gpio_chip’ has no member named ‘of_node’
gc->of_node = bank->of_node;
^

Rework the dependencies so all Samsung drivers and common
PINCTRL_SAMSUNG part depend on OF_GPIO (which is default yes if GPIOLIB
and OF are enabled).

Reported-by: Chen Zhou <chenzhou10@huawei.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

+4 -2
+4 -2
drivers/pinctrl/samsung/Kconfig
··· 4 4 # 5 5 config PINCTRL_SAMSUNG 6 6 bool 7 + depends on OF_GPIO 7 8 select PINMUX 8 9 select PINCONF 9 10 10 11 config PINCTRL_EXYNOS 11 12 bool "Pinctrl common driver part for Samsung Exynos SoCs" 12 - depends on OF && GPIOLIB 13 + depends on OF_GPIO 13 14 depends on ARCH_EXYNOS || ARCH_S5PV210 || COMPILE_TEST 14 15 select PINCTRL_SAMSUNG 15 16 select PINCTRL_EXYNOS_ARM if ARM && (ARCH_EXYNOS || ARCH_S5PV210) ··· 26 25 27 26 config PINCTRL_S3C24XX 28 27 bool "Samsung S3C24XX SoC pinctrl driver" 29 - depends on OF 28 + depends on OF_GPIO 30 29 depends on ARCH_S3C24XX || COMPILE_TEST 31 30 select PINCTRL_SAMSUNG 32 31 33 32 config PINCTRL_S3C64XX 34 33 bool "Samsung S3C64XX SoC pinctrl driver" 34 + depends on OF_GPIO 35 35 depends on ARCH_S3C64XX || COMPILE_TEST 36 36 select PINCTRL_SAMSUNG