Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ALSA: snd-aoa: add of_node_put() in error path

Both calls to of_find_node_by_name() and of_get_next_child() return a
node pointer with refcount incremented thus it must be explicidly
decremented here after the last usage. As we are assured to have a
refcounted np either from the initial
of_find_node_by_name(NULL, name); or from the of_get_next_child(gpio, np)
in the while loop if we reached the error code path below, an
x of_node_put(np) is needed.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Fixes: commit f3d9478b2ce4 ("[ALSA] snd-aoa: add snd-aoa")
Signed-off-by: Takashi Iwai <tiwai@suse.de>

authored by

Nicholas Mc Guire and committed by
Takashi Iwai
222bce5e fdd49c51

+3 -1
+3 -1
sound/aoa/core/gpio-feature.c
··· 88 88 } 89 89 90 90 reg = of_get_property(np, "reg", NULL); 91 - if (!reg) 91 + if (!reg) { 92 + of_node_put(np); 92 93 return NULL; 94 + } 93 95 94 96 *gpioptr = *reg; 95 97