Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: Add missing dependencies on NETDEVICES

ETRAX_ETHERNET selects ETHERNET and MII, which depend on NETDEVICES.
I don't think anything should select NETDEVICES, so make it a
dependency. It also doesn't need to select or depend on ETHERNET,
which has nothing to do with the Ethernet library functions.

BPCTL selects MII, which depends on NETDEVICES. But everything in the
drivers/staging/silicom directory is related to net devices, so make
NET_VENDOR_SILICOM depend on NETDEVICES and remove the now-redundant
dependencies on NET.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Ben Hutchings and committed by
David S. Miller
2206209e d6cf7a86

+5 -7
+1 -2
arch/cris/arch-v10/drivers/Kconfig
··· 2 2 3 3 config ETRAX_ETHERNET 4 4 bool "Ethernet support" 5 - depends on ETRAX_ARCH_V10 6 - select ETHERNET 5 + depends on ETRAX_ARCH_V10 && NETDEVICES 7 6 select MII 8 7 help 9 8 This option enables the ETRAX 100LX built-in 10/100Mbit Ethernet
+1 -2
arch/cris/arch-v32/drivers/Kconfig
··· 2 2 3 3 config ETRAX_ETHERNET 4 4 bool "Ethernet support" 5 - depends on ETRAX_ARCH_V32 6 - select ETHERNET 5 + depends on ETRAX_ARCH_V32 && NETDEVICES 7 6 select MII 8 7 help 9 8 This option enables the ETRAX FS built-in 10/100Mbit Ethernet
+3 -3
drivers/staging/silicom/Kconfig
··· 5 5 config NET_VENDOR_SILICOM 6 6 bool "Silicom devices" 7 7 default y 8 - depends on PCI 8 + depends on PCI && NETDEVICES 9 9 ---help--- 10 10 If you have a network card (Ethernet) belonging to this class, 11 11 say Y. ··· 19 19 20 20 config SBYPASS 21 21 tristate "Silicom BypassCTL library support" 22 - depends on PCI && NET 22 + depends on PCI 23 23 depends on m 24 24 ---help--- 25 25 If you have a network (Ethernet) controller of this type, say Y ··· 29 29 30 30 config BPCTL 31 31 tristate "Silicom BypassCTL net support" 32 - depends on PCI && NET 32 + depends on PCI 33 33 depends on m 34 34 select SBYPASS 35 35 select MII