Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ARM: integrator: impd1: use struct_size() in devm_kzalloc()

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
int stuff;
void *entry[];
};

instance = devm_kzalloc(dev, sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = devm_kzalloc(dev, struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

authored by

Gustavo A. R. Silva and committed by
Linus Walleij
21face6f df209c43

+1 -1
+1 -1
arch/arm/mach-integrator/impd1.c
··· 390 390 char *mmciname; 391 391 392 392 lookup = devm_kzalloc(&dev->dev, 393 - sizeof(*lookup) + 3 * sizeof(struct gpiod_lookup), 393 + struct_size(lookup, table, 3), 394 394 GFP_KERNEL); 395 395 chipname = devm_kstrdup(&dev->dev, devname, GFP_KERNEL); 396 396 mmciname = devm_kasprintf(&dev->dev, GFP_KERNEL,