Merge tag 'perf-urgent-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent

Pull perf/urgent fixes from Arnaldo Carvalho de Melo:

- In some cases where perf_event.fork.{pid,tid} should be used we were instead
using perf_event.comm.{pid,tid}, which is not a problem for for the 'pid'
case, that sits in the same place in these union_perf_event members, but
comm.tid sits where fork.ppid is, oops.

These cases were considered as (potentially) problematic:

- 'perf script' with !sample_id_all, i.e. only non old kernels without
perf_event_attr.sample_id_all.

- intel_pt could be affected when decoding without timestamps, as the exit
event is only used to flush out data which anyway gets flushed at the
end of the session.

- intel_bts also uses the exit event to flush data which would probably not
cause errors as it would get flushed at the end of the session instead.

Fix it. (Adrian Hunter)

- Due to relaxing the compiler checks for bison generated files, we missed
updating one parse_events_add_pmu() caller when this function had its
prototype changed, fix it. (Jiri Olsa)

Signed-off-by: Arnaldo Carvalho de Melo <[e-mail]>
Signed-off-by: Ingo Molnar <[e-mail]>

tools/perf/builtin-script.c

···
 	if (!evsel->attr.sample_id_all) {
 		sample->cpu = 0;
 		sample->time = 0;
-		sample->tid = event->comm.tid;
-		sample->pid = event->comm.pid;
+		sample->tid = event->fork.tid;
+		sample->pid = event->fork.pid;
 	}
 	print_sample_start(sample, thread, evsel);
 	perf_event__fprintf(event, stdout);

tools/perf/util/intel-bts.c

···
 	if (err)
 		return err;
 	if (event->header.type == PERF_RECORD_EXIT) {
-		err = intel_bts_process_tid_exit(bts, event->comm.tid);
+		err = intel_bts_process_tid_exit(bts, event->fork.tid);
 		if (err)
 			return err;
 	}

tools/perf/util/intel-pt.c

···
 	if (pt->timeless_decoding) {
 		if (event->header.type == PERF_RECORD_EXIT) {
 			err = intel_pt_process_timeless_queues(pt,
-							       event->comm.tid,
+							       event->fork.tid,
 							       sample->time);
 		}
 	} else if (timestamp) {

tools/perf/util/parse-events.y

···
 	list_add_tail(&term->list, head);
 
 	ALLOC_LIST(list);
-	ABORT_ON(parse_events_add_pmu(list, &data->idx, "cpu", head));
+	ABORT_ON(parse_events_add_pmu(data, list, "cpu", head));
 	parse_events__free_terms(head);
 	$$ = list;
 }