Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

PCI: mediatek: Fix refcount leak in mtk_pcie_subsys_powerup()

The of_find_compatible_node() function returns a node pointer with
refcount incremented, We should use of_node_put() on it when done
Add the missing of_node_put() to release the refcount.

Link: https://lore.kernel.org/r/20220309091953.5630-1-linmq006@gmail.com
Fixes: 87e8657ba99c ("PCI: mediatek: Add new method to get shared pcie-cfg base address")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Miles Chen <miles.chen@mediatek.com>
Acked-by: Rob Herring <robh@kernel.org>

authored by

Miaoqian Lin and committed by
Lorenzo Pieralisi
214e0d8f 31231092

+1
+1
drivers/pci/controller/pcie-mediatek.c
··· 1008 1008 "mediatek,generic-pciecfg"); 1009 1009 if (cfg_node) { 1010 1010 pcie->cfg = syscon_node_to_regmap(cfg_node); 1011 + of_node_put(cfg_node); 1011 1012 if (IS_ERR(pcie->cfg)) 1012 1013 return PTR_ERR(pcie->cfg); 1013 1014 }