Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

gpio: tc35894: fix up tc35894 interrupt configuration

The offset of regmap is incorrect, j * 8 is move to the
wrong register.

for example:

asume i = 0, j = 1. we want to set KPY5 as interrupt
falling edge mode, regmap[0][1] should be TC3589x_GPIOIBE1 0xcd
but, regmap[i] + j * 8 = TC3589x_GPIOIBE0 + 8 ,point to 0xd4,
this is TC3589x_GPIOIE2 not TC3589x_GPIOIBE1.

Fixes: d88b25be3584 ("gpio: Add TC35892 GPIO driver")
Cc: Cc: stable@vger.kernel.org
Signed-off-by: dillon min <dillon.minfei@gmail.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

authored by

dillon min and committed by
Bartosz Golaszewski
214b0e1a 5fcface6

+1 -1
+1 -1
drivers/gpio/gpio-tc3589x.c
··· 212 212 continue; 213 213 214 214 tc3589x_gpio->oldregs[i][j] = new; 215 - tc3589x_reg_write(tc3589x, regmap[i] + j * 8, new); 215 + tc3589x_reg_write(tc3589x, regmap[i] + j, new); 216 216 } 217 217 } 218 218