[NET_SCHED] sch_htb: htb_requeue fix

htb_requeue() enqueues skbs for which htb_classify() returns NULL.
This is wrong because such skbs could be handled by NET_CLS_ACT code,
and the decision could be different than earlier in htb_enqueue().
So htb_requeue() is changed to work and look more like htb_enqueue().

Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by Jarek Poplawski and committed by David S. Miller 21347456 238fc7ea

+10 -3
+10 -3
net/sched/sch_htb.c
··· 609 /* TODO: requeuing packet charges it to policers again !! */ 610 static int htb_requeue(struct sk_buff *skb, struct Qdisc *sch) 611 { 612 struct htb_sched *q = qdisc_priv(sch); 613 - int ret = NET_XMIT_SUCCESS; 614 struct htb_class *cl = htb_classify(skb, sch, &ret); 615 struct sk_buff *tskb; 616 617 - if (cl == HTB_DIRECT || !cl) { 618 /* enqueue to helper queue */ 619 - if (q->direct_queue.qlen < q->direct_qlen && cl) { 620 __skb_queue_head(&q->direct_queue, skb); 621 } else { 622 __skb_queue_head(&q->direct_queue, skb); ··· 625 sch->qstats.drops++; 626 return NET_XMIT_CN; 627 } 628 } else if (cl->un.leaf.q->ops->requeue(skb, cl->un.leaf.q) != 629 NET_XMIT_SUCCESS) { 630 sch->qstats.drops++;
··· 609 /* TODO: requeuing packet charges it to policers again !! */ 610 static int htb_requeue(struct sk_buff *skb, struct Qdisc *sch) 611 { 612 + int ret; 613 struct htb_sched *q = qdisc_priv(sch); 614 struct htb_class *cl = htb_classify(skb, sch, &ret); 615 struct sk_buff *tskb; 616 617 + if (cl == HTB_DIRECT) { 618 /* enqueue to helper queue */ 619 + if (q->direct_queue.qlen < q->direct_qlen) { 620 __skb_queue_head(&q->direct_queue, skb); 621 } else { 622 __skb_queue_head(&q->direct_queue, skb); ··· 625 sch->qstats.drops++; 626 return NET_XMIT_CN; 627 } 628 + #ifdef CONFIG_NET_CLS_ACT 629 + } else if (!cl) { 630 + if (ret == NET_XMIT_BYPASS) 631 + sch->qstats.drops++; 632 + kfree_skb(skb); 633 + return ret; 634 + #endif 635 } else if (cl->un.leaf.q->ops->requeue(skb, cl->un.leaf.q) != 636 NET_XMIT_SUCCESS) { 637 sch->qstats.drops++;