Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

scsi: st: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where
we are expecting to fall through.

Addresses-Coverity-ID: 114994 ("Missing break in switch")
Addresses-Coverity-ID: 114995 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Kai Mäkisara <kai.makisara@kolumbus.fi>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Gustavo A. R. Silva and committed by
Martin K. Petersen
211d62a8 fc9ac87e

+4
+4
drivers/scsi/st.c
··· 337 337 switch (sense[0] & 0x7f) { 338 338 case 0x71: 339 339 s->deferred = 1; 340 + /* fall through */ 340 341 case 0x70: 341 342 s->fixed_format = 1; 342 343 s->flags = sense[2] & 0xe0; 343 344 break; 344 345 case 0x73: 345 346 s->deferred = 1; 347 + /* fall through */ 346 348 case 0x72: 347 349 s->fixed_format = 0; 348 350 ucp = scsi_sense_desc_find(sense, SCSI_SENSE_BUFFERSIZE, 4); ··· 2723 2721 switch (cmd_in) { 2724 2722 case MTFSFM: 2725 2723 chg_eof = 0; /* Changed from the FSF after this */ 2724 + /* fall through */ 2726 2725 case MTFSF: 2727 2726 cmd[0] = SPACE; 2728 2727 cmd[1] = 0x01; /* Space FileMarks */ ··· 2738 2735 break; 2739 2736 case MTBSFM: 2740 2737 chg_eof = 0; /* Changed from the FSF after this */ 2738 + /* fall through */ 2741 2739 case MTBSF: 2742 2740 cmd[0] = SPACE; 2743 2741 cmd[1] = 0x01; /* Space FileMarks */