Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

clk: clk-wm831x: fix a logic error

Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188561. Function
wm831x_clkout_is_prepared() returns "true" when it fails to read
CLOCK_CONTROL_1. "true" means the device is already prepared. So
return "true" on the read failure seems improper.

Signed-off-by: Pan Bian <bianpan2016@163.com>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Fixes: f05259a6ffa4 ("clk: wm831x: Add initial WM831x clock driver")
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

authored by

Pan Bian and committed by
Stephen Boyd
20979202 1221ae21

+1 -1
+1 -1
drivers/clk/clk-wm831x.c
··· 243 243 if (ret < 0) { 244 244 dev_err(wm831x->dev, "Unable to read CLOCK_CONTROL_1: %d\n", 245 245 ret); 246 - return true; 246 + return false; 247 247 } 248 248 249 249 return (ret & WM831X_CLKOUT_ENA) != 0;