Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

tcp: tcp_send_challenge_ack delete useless param `skb`

After this parameter is passed in, there is no usage, and deleting it will
not bring any impact.

Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Benjamin Yim <yan2228598786@gmail.com>
Link: https://lore.kernel.org/r/20220109130824.2776-1-yan2228598786@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Benjamin Yim and committed by
Jakub Kicinski
208dd45d 0959a82a

+5 -5
+5 -5
net/ipv4/tcp_input.c
··· 3601 3601 } 3602 3602 3603 3603 /* RFC 5961 7 [ACK Throttling] */ 3604 - static void tcp_send_challenge_ack(struct sock *sk, const struct sk_buff *skb) 3604 + static void tcp_send_challenge_ack(struct sock *sk) 3605 3605 { 3606 3606 /* unprotected vars, we dont care of overwrites */ 3607 3607 static u32 challenge_timestamp; ··· 3763 3763 /* RFC 5961 5.2 [Blind Data Injection Attack].[Mitigation] */ 3764 3764 if (before(ack, prior_snd_una - tp->max_window)) { 3765 3765 if (!(flag & FLAG_NO_CHALLENGE_ACK)) 3766 - tcp_send_challenge_ack(sk, skb); 3766 + tcp_send_challenge_ack(sk); 3767 3767 return -1; 3768 3768 } 3769 3769 goto old_ack; ··· 5726 5726 if (tp->syn_fastopen && !tp->data_segs_in && 5727 5727 sk->sk_state == TCP_ESTABLISHED) 5728 5728 tcp_fastopen_active_disable(sk); 5729 - tcp_send_challenge_ack(sk, skb); 5729 + tcp_send_challenge_ack(sk); 5730 5730 } 5731 5731 goto discard; 5732 5732 } ··· 5741 5741 if (syn_inerr) 5742 5742 TCP_INC_STATS(sock_net(sk), TCP_MIB_INERRS); 5743 5743 NET_INC_STATS(sock_net(sk), LINUX_MIB_TCPSYNCHALLENGE); 5744 - tcp_send_challenge_ack(sk, skb); 5744 + tcp_send_challenge_ack(sk); 5745 5745 goto discard; 5746 5746 } 5747 5747 ··· 6456 6456 if (!acceptable) { 6457 6457 if (sk->sk_state == TCP_SYN_RECV) 6458 6458 return 1; /* send one RST */ 6459 - tcp_send_challenge_ack(sk, skb); 6459 + tcp_send_challenge_ack(sk); 6460 6460 goto discard; 6461 6461 } 6462 6462 switch (sk->sk_state) {