[media] tuners: Refactoring for m88rs6000t_sleep()

Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

kernel os linux

This issue was detected by using the Coccinelle software.

1. Let us return directly if a call of the regmap_write() function failed.

2. Delete the jump label "err" then.

3. Return zero as a constant at the end.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

authored by

Markus Elfring and committed by

Mauro Carvalho Chehab 10 years ago 2050d14c c2e5c951

+5 -6

1 changed file

expand all

drivers

media

tuners

m88rs6000t.c

+5 -6

drivers/media/tuners/m88rs6000t.c

··· 461 461 dev_dbg(&dev->client->dev, "%s:\n", __func__); 462 462 463 463 ret = regmap_write(dev->regmap, 0x07, 0x6d); 464 - if (ret) 465 - goto err; 466 - usleep_range(5000, 10000); 467 - err: 468 - if (ret) 464 + if (ret) { 469 465 dev_dbg(&dev->client->dev, "failed=%d\n", ret); 470 - return ret; 466 + return ret; 467 + } 468 + usleep_range(5000, 10000); 469 + return 0; 471 470 } 472 471 473 472 static int m88rs6000t_get_frequency(struct dvb_frontend *fe, u32 *frequency)