Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
tjh.dev
kernel
os
linux
[PATCH] synclink_gt: fix receive tty error handling
Fix receive tty error handling in synclink_gt driver. Adrian reported
compiler warning for incorrect bit test against char variable. I
determined these and other device specific error bits were incorrectly
defined.
Signed-off-by: Paul Fulghum <paulkf@microgate.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
authored by Paul Fulghum and committed by Linus Torvalds 202af6d5 ddac7c7e
+7
-7
drivers/char/synclink_gt.c
+7
-7
drivers/char/synclink_gt.c
···
391
#define DESC_LIST_SIZE 4096
392
393
#define MASK_PARITY BIT1
394
-
#define MASK_FRAMING BIT2
395
-
#define MASK_BREAK BIT3
396
#define MASK_OVERRUN BIT4
397
398
#define GSR 0x00 /* global status */
···
1800
1801
stat = 0;
1802
1803
-
if ((status = *(p+1) & (BIT9 + BIT8))) {
1804
-
if (status & BIT9)
1805
icount->parity++;
1806
-
else if (status & BIT8)
1807
icount->frame++;
1808
/* discard char if tty control flags say so */
1809
if (status & info->ignore_status_mask)
1810
continue;
1811
-
if (status & BIT9)
1812
stat = TTY_PARITY;
1813
-
else if (status & BIT8)
1814
stat = TTY_FRAME;
1815
}
1816
if (tty) {
···
391
#define DESC_LIST_SIZE 4096
392
393
#define MASK_PARITY BIT1
394
+
#define MASK_FRAMING BIT0
395
+
#define MASK_BREAK BIT14
396
#define MASK_OVERRUN BIT4
397
398
#define GSR 0x00 /* global status */
···
1800
1801
stat = 0;
1802
1803
+
if ((status = *(p+1) & (BIT1 + BIT0))) {
1804
+
if (status & BIT1)
1805
icount->parity++;
1806
+
else if (status & BIT0)
1807
icount->frame++;
1808
/* discard char if tty control flags say so */
1809
if (status & info->ignore_status_mask)
1810
continue;
1811
+
if (status & BIT1)
1812
stat = TTY_PARITY;
1813
+
else if (status & BIT0)
1814
stat = TTY_FRAME;
1815
}
1816
if (tty) {