Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ARM: dts: fix pinctrl for s2mps11-irq on exynos5420-arndale-octa

On Arndale Octa the S2MPS11 RTC alarm interrupt was not handled
at all because of wrong configuration of interrupt and gpx3-2.
1. Interrupt is signaled by falling edge.
2. This GPIO line is hard-wired on the board to PVDD_APIO_1V8
through a resistor so pull-up/down must be disabled.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Kukjin Kim <kgene@kernel.org>

authored by

Krzysztof Kozlowski and committed by
Kukjin Kim
1fed2252 d1ed0d21

+12 -1
+12 -1
arch/arm/boot/dts/exynos5420-arndale-octa.dts
··· 90 90 s2mps11,buck4-ramp-enable = <1>; 91 91 92 92 interrupt-parent = <&gpx3>; 93 - interrupts = <2 IRQ_TYPE_LEVEL_HIGH>; 93 + interrupts = <2 IRQ_TYPE_EDGE_FALLING>; 94 + pinctrl-names = "default"; 95 + pinctrl-0 = <&s2mps11_irq>; 94 96 95 97 s2mps11_osc: clocks { 96 98 #clock-cells = <1>; ··· 377 375 378 376 &cci { 379 377 status = "disabled"; 378 + }; 379 + 380 + &pinctrl_0 { 381 + s2mps11_irq: s2mps11-irq { 382 + samsung,pins = "gpx3-2"; 383 + samsung,pin-function = <0xf>; 384 + samsung,pin-pud = <0>; 385 + samsung,pin-drv = <0>; 386 + }; 380 387 };