Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/panel-novatek-nt35510: Emit an error message if power off fails

Returning an error code from a mipi_dsi remove callback fails, this is
silently ignored. (mipi_dsi_drv_remove() propagates the return value to
device_remove() which ignores it.) So emit an error code in the driver
remove function and return 0.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220708094922.1408248-3-u.kleine-koenig@pengutronix.de

authored by

Uwe Kleine-König and committed by
Sam Ravnborg
1fd452c4 d72ac4bb

+4 -1
+4 -1
drivers/gpu/drm/panel/panel-novatek-nt35510.c
··· 974 974 mipi_dsi_detach(dsi); 975 975 /* Power off */ 976 976 ret = nt35510_power_off(nt); 977 + if (ret) 978 + dev_err(&dsi->dev, "Failed to power off\n"); 979 + 977 980 drm_panel_remove(&nt->panel); 978 981 979 - return ret; 982 + return 0; 980 983 } 981 984 982 985 /*