Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

clk: qcom: mmcc-msm8998: Fix the SMMU GDSC

The SMMU GDSC doesn't have to be ALWAYS-ON and shouldn't feature the
HW_CTRL flag (it's separate from hw_ctrl_addr). In addition to that,
it should feature a cxc entry for bimc_smmu_axi_clk and be marked as
votable.

Fix all of these issues.

Fixes: d14b15b5931c ("clk: qcom: Add MSM8998 Multimedia Clock Controller (MMCC) driver")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Link: https://lore.kernel.org/r/20230531-topic-8998_mmssclk-v3-5-ba1b1fd9ee75@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>

authored by

Konrad Dybcio and committed by
Bjorn Andersson
1fc62c83 9906c414

+3 -1
+3 -1
drivers/clk/qcom/mmcc-msm8998.c
··· 2610 2610 static struct gdsc bimc_smmu_gdsc = { 2611 2611 .gdscr = 0xe020, 2612 2612 .gds_hw_ctrl = 0xe024, 2613 + .cxcs = (unsigned int []){ 0xe008 }, 2614 + .cxc_count = 1, 2613 2615 .pd = { 2614 2616 .name = "bimc_smmu", 2615 2617 }, 2616 2618 .pwrsts = PWRSTS_OFF_ON, 2617 - .flags = HW_CTRL | ALWAYS_ON, 2619 + .flags = VOTABLE, 2618 2620 }; 2619 2621 2620 2622 static struct clk_regmap *mmcc_msm8998_clocks[] = {