Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

cpufreq: Avoid printing kernel addresses in cpufreq_resume()

The pointer value of policy and driver structure are currently printed
in the error messages of cpufreq_resume(), this is not recommended and
helpful.

In order to be consistent with the error message in cpufreq_suspend()
and easier to understand, print the name of driver strcture and the
manage CPU of policy structure individually in the error messages of
cpufreq_resume().

Link: https://lore.kernel.org/all/b7be717c-41d8-bbbf-3e97-3799948ab757@huawei.com
Signed-off-by: Liao Chang <liaochang1@huawei.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

authored by

Liao Chang and committed by
Rafael J. Wysocki
1f464cb4 ccc5e981

+4 -4
+4 -4
drivers/cpufreq/cpufreq.c
··· 1943 1943 1944 1944 for_each_active_policy(policy) { 1945 1945 if (cpufreq_driver->resume && cpufreq_driver->resume(policy)) { 1946 - pr_err("%s: Failed to resume driver: %p\n", __func__, 1947 - policy); 1946 + pr_err("%s: Failed to resume driver: %s\n", __func__, 1947 + cpufreq_driver->name); 1948 1948 } else if (has_target()) { 1949 1949 down_write(&policy->rwsem); 1950 1950 ret = cpufreq_start_governor(policy); 1951 1951 up_write(&policy->rwsem); 1952 1952 1953 1953 if (ret) 1954 - pr_err("%s: Failed to start governor for policy: %p\n", 1955 - __func__, policy); 1954 + pr_err("%s: Failed to start governor for CPU%u's policy\n", 1955 + __func__, policy->cpu); 1956 1956 } 1957 1957 } 1958 1958 }