Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

perf ui tui progress: Implement the ui_progress_ops->finish() method

So that we can erase the progress bar after we're done with it, avoiding
things like:

-------------------------------------------------------------------

┌─Error:──────────────────────────────────────────────────────┐
│Can't annotate unmapped_area_topdown: │
│ │
│No vmlinux file with build id a826726b5ddacfab1f0bade868f1a79│
│was found in the path. │
│ │
│Note that annotation using /proc/kcore requires CAP_SYS_RAWIO│
┌Processin│ │──┐
│ │Please use: │ │
└─────────│ │──┘
│ perf buildid-cache -vu vmlinux │
│ │
│or: │
│ │
│ --vmlinux vmlinux │
│ │
│ │
│Press any key... │
└─────────────────────────────────────────────────────────────┘

Can't annotate unmapped_area_topdown:
-------------------------------------------------------------------

I.e. that finished progress bar behind the error window. It is not a
problem when we end up redrawing the whole screen, but its ugly when
we present such error windows, provide a TUI method so that code like
the above may avoid this situation, as will be done with the annotation
code in the next cset.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-qvktnojzwwe37pweging058t@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

+18 -1
+18 -1
tools/perf/ui/tui/progress.c
··· 33 33 pthread_mutex_unlock(&ui__lock); 34 34 } 35 35 36 + static void tui_progress__finish(void) 37 + { 38 + int y; 39 + 40 + if (use_browser <= 0) 41 + return; 42 + 43 + ui__refresh_dimensions(false); 44 + pthread_mutex_lock(&ui__lock); 45 + y = SLtt_Screen_Rows / 2 - 2; 46 + SLsmg_set_color(0); 47 + SLsmg_fill_region(y, 0, 3, SLtt_Screen_Cols, ' '); 48 + SLsmg_refresh(); 49 + pthread_mutex_unlock(&ui__lock); 50 + } 51 + 36 52 static struct ui_progress_ops tui_progress__ops = 37 53 { 38 - .update = tui_progress__update, 54 + .update = tui_progress__update, 55 + .finish = tui_progress__finish, 39 56 }; 40 57 41 58 void tui_progress__init(void)