Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

leds: Use kcalloc instead of kzalloc to allocate array

The advantage of kcalloc is that will prevent integer overflows which
could result from the multiplication of number of elements and size and it
is also a bit nicer to read.

The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Cc: Bryan Wu <bryan.wu@canonical.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Thomas Meyer and committed by
Linus Torvalds
1daef6d2 872b86be

+1 -1
+1 -1
drivers/leds/leds-mc13783.c
··· 280 280 return -EINVAL; 281 281 } 282 282 283 - led = kzalloc(sizeof(*led) * pdata->num_leds, GFP_KERNEL); 283 + led = kcalloc(pdata->num_leds, sizeof(*led), GFP_KERNEL); 284 284 if (led == NULL) { 285 285 dev_err(&pdev->dev, "failed to alloc memory\n"); 286 286 return -ENOMEM;