Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

USB: isp116x: remove dependency on CONFIG_USB_DEBUG

Move all debugging messages in the driver to use the dynamic debug
subsystem, and not rely on CONFIG_USB_DEBUG to turn them on or off.

This lets debugging be enabled without having to rebuild the driver, an
important thing for users that can not do it.

It also removes the pointless IRQ_TEST() macro, as that was totally
useless and obviously never used.

Cc: Olav Kongas <ok@artecdesign.ee>
Acked-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

+1 -12
+1 -12
drivers/usb/host/isp116x.h
··· 325 325 326 326 /*-------------------------------------------------------------------------*/ 327 327 328 - #ifdef DEBUG 329 - #define DBG(stuff...) printk(KERN_DEBUG "116x: " stuff) 330 - #else 331 - #define DBG(stuff...) do{}while(0) 332 - #endif 328 + #define DBG(stuff...) pr_debug("116x: " stuff) 333 329 334 330 #ifdef VERBOSE 335 331 # define VDBG DBG ··· 354 358 #define isp116x_check_platform_delay(h) 0 355 359 #endif 356 360 357 - #if defined(DEBUG) 358 - #define IRQ_TEST() BUG_ON(!irqs_disabled()) 359 - #else 360 - #define IRQ_TEST() do{}while(0) 361 - #endif 362 - 363 361 static inline void isp116x_write_addr(struct isp116x *isp116x, unsigned reg) 364 362 { 365 - IRQ_TEST(); 366 363 writew(reg & 0xff, isp116x->addr_reg); 367 364 isp116x_delay(isp116x, 300); 368 365 }