Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mm: BUG when __kmap_atomic_idx equals KM_TYPE_NR

__kmap_atomic_idx is per_cpu variable. Each CPU can use KM_TYPE_NR
entries from FIXMAP i.e. from 0 to KM_TYPE_NR - 1. Allowing
__kmap_atomic_idx to over- shoot to KM_TYPE_NR can mess up with next
CPU's 0th entry which is a bug. Hence BUG_ON if __kmap_atomic_idx >=
KM_TYPE_NR.

Fix the off-by-on in this test.

Signed-off-by: Chintan Pandya <cpandya@codeaurora.org>
Cc: David Rientjes <rientjes@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Chintan Pandya and committed by
Linus Torvalds
1d352bfd 61e02c74

+1 -1
+1 -1
include/linux/highmem.h
··· 93 93 94 94 #ifdef CONFIG_DEBUG_HIGHMEM 95 95 WARN_ON_ONCE(in_irq() && !irqs_disabled()); 96 - BUG_ON(idx > KM_TYPE_NR); 96 + BUG_ON(idx >= KM_TYPE_NR); 97 97 #endif 98 98 return idx; 99 99 }