Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ipv4: Don't use enums as bitmasks in ip_fragment.c

Noticed by Joe Perches.

Signed-off-by: David S. Miller <davem@davemloft.net>

+4 -6
+4 -6
net/ipv4/ip_fragment.c
··· 81 81 * We want to check ECN values of all fragments, do detect invalid combinations. 82 82 * In ipq->ecn, we store the OR value of each ip4_frag_ecn() fragment value. 83 83 */ 84 - enum { 85 - IPFRAG_ECN_NOT_ECT = 0x01, /* one frag had ECN_NOT_ECT */ 86 - IPFRAG_ECN_ECT_1 = 0x02, /* one frag had ECN_ECT_1 */ 87 - IPFRAG_ECN_ECT_0 = 0x04, /* one frag had ECN_ECT_0 */ 88 - IPFRAG_ECN_CE = 0x08, /* one frag had ECN_CE */ 89 - }; 84 + #define IPFRAG_ECN_NOT_ECT 0x01 /* one frag had ECN_NOT_ECT */ 85 + #define IPFRAG_ECN_ECT_1 0x02 /* one frag had ECN_ECT_1 */ 86 + #define IPFRAG_ECN_ECT_0 0x04 /* one frag had ECN_ECT_0 */ 87 + #define IPFRAG_ECN_CE 0x08 /* one frag had ECN_CE */ 90 88 91 89 static inline u8 ip4_frag_ecn(u8 tos) 92 90 {