tracing: Fix return value of __setup handlers

__setup() handlers should generally return 1 to indicate that the
boot options have been handled.

Using invalid option values causes the entire kernel boot option
string to be reported as Unknown and added to init's environment
strings, polluting it.

Unknown kernel command line parameters "BOOT_IMAGE=/boot/bzImage-517rc6
kprobe_event=p,syscall_any,$arg1 trace_options=quiet
trace_clock=jiffies", will be passed to user space.

Run /sbin/init as init process
with arguments:
/sbin/init
with environment:
HOME=/
TERM=linux
BOOT_IMAGE=/boot/bzImage-517rc6
kprobe_event=p,syscall_any,$arg1
trace_options=quiet
trace_clock=jiffies

Return 1 from the __setup() handlers so that init's environment is not
polluted with kernel boot options.

Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru
Link: https://lkml.kernel.org/r/20220303031744.32356-1-rdunlap@infradead.org

Cc: stable@vger.kernel.org
Fixes: 7bcfaf54f591 ("tracing: Add trace_options kernel command line parameter")
Fixes: e1e232ca6b8f ("tracing: Add trace_clock=<clock> kernel parameter")
Fixes: 970988e19eb0 ("tracing/kprobe: Add kprobe_event= boot parameter")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: Igor Zhbanov <i.zhbanov@omprussia.ru>
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>

authored by Randy Dunlap and committed by Steven Rostedt (Google) 1d02b444 1d1898f6

Changed files
+3 -3
kernel
+2 -2
kernel/trace/trace.c
··· 235 235 static int __init set_trace_boot_options(char *str) 236 236 { 237 237 strlcpy(trace_boot_options_buf, str, MAX_TRACER_SIZE); 238 - return 0; 238 + return 1; 239 239 } 240 240 __setup("trace_options=", set_trace_boot_options); 241 241 ··· 246 246 { 247 247 strlcpy(trace_boot_clock_buf, str, MAX_TRACER_SIZE); 248 248 trace_boot_clock = trace_boot_clock_buf; 249 - return 0; 249 + return 1; 250 250 } 251 251 __setup("trace_clock=", set_trace_boot_clock); 252 252
+1 -1
kernel/trace/trace_kprobe.c
··· 32 32 strlcpy(kprobe_boot_events_buf, str, COMMAND_LINE_SIZE); 33 33 disable_tracing_selftest("running kprobe events"); 34 34 35 - return 0; 35 + return 1; 36 36 } 37 37 __setup("kprobe_event=", set_kprobe_boot_events); 38 38