Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ALSA: hda: Fix missing pointer check in hda_component_manager_init function

The __component_match_add function may assign the 'matchptr' pointer
the value ERR_PTR(-ENOMEM), which will subsequently be dereferenced.

The call stack leading to the error looks like this:

hda_component_manager_init
|-> component_match_add
|-> component_match_add_release
|-> __component_match_add ( ... ,**matchptr, ... )
|-> *matchptr = ERR_PTR(-ENOMEM); // assign
|-> component_master_add_with_match( ... match)
|-> component_match_realloc(match, match->num); // dereference

Add IS_ERR() check to prevent the crash.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: ae7abe36e352 ("ALSA: hda/realtek: Add CS35L41 support for Thinkpad laptops")
Cc: stable@vger.kernel.org
Signed-off-by: Denis Arefev <arefev@swemel.ru>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

authored by

Denis Arefev and committed by
Takashi Iwai
1cf11d80 8527bbb3

+4
+4
sound/hda/codecs/side-codecs/hda_component.c
··· 174 174 sm->match_str = match_str; 175 175 sm->index = i; 176 176 component_match_add(dev, &match, hda_comp_match_dev_name, sm); 177 + if (IS_ERR(match)) { 178 + codec_err(cdc, "Fail to add component %ld\n", PTR_ERR(match)); 179 + return PTR_ERR(match); 180 + } 177 181 } 178 182 179 183 ret = component_master_add_with_match(dev, ops, match);