tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

staging: rtl8723bs: Remove function pointer hal_deinit

Remove function pointer hal_deinit and use rtl8723bs_hal_deinit directly
to increase readability.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/b0acbbdc372e01baabd1d98f824bc2a3c6c4c600.1727966761.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Philipp Hortmann and committed by
Greg Kroah-Hartman 1ce42b5f 5e0cadea

+3 -6
+1 -1
drivers/staging/rtl8723bs/hal/hal_intf.c
··· 107 107 uint status = _SUCCESS; 108 108 struct dvobj_priv *dvobj = adapter_to_dvobj(padapter); 109 109 110 - status = padapter->HalFunc.hal_deinit(padapter); 110 + status = rtl8723bs_hal_deinit(padapter); 111 111 112 112 if (status == _SUCCESS) { 113 113 padapter = dvobj->padapters;
+1 -3
drivers/staging/rtl8723bs/hal/sdio_halinit.c
··· 884 884 HalPwrSeqCmdParsing(padapter, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_SDIO_MSK, rtl8723B_card_disable_flow); 885 885 } 886 886 887 - static u32 rtl8723bs_hal_deinit(struct adapter *padapter) 887 + u32 rtl8723bs_hal_deinit(struct adapter *padapter) 888 888 { 889 889 struct dvobj_priv *psdpriv = padapter->dvobj; 890 890 struct debug_priv *pdbgpriv = &psdpriv->drv_dbg; ··· 1258 1258 struct hal_ops *pHalFunc = &padapter->HalFunc; 1259 1259 1260 1260 rtl8723b_set_hal_ops(pHalFunc); 1261 - 1262 - pHalFunc->hal_deinit = &rtl8723bs_hal_deinit; 1263 1261 1264 1262 pHalFunc->init_xmit_priv = &rtl8723bs_init_xmit_priv; 1265 1263 pHalFunc->free_xmit_priv = &rtl8723bs_free_xmit_priv;
-2
drivers/staging/rtl8723bs/include/hal_intf.h
··· 162 162 typedef s32 (*c2h_id_filter)(u8 *c2h_evt); 163 163 164 164 struct hal_ops { 165 - u32 (*hal_deinit)(struct adapter *padapter); 166 - 167 165 void (*free_hal_data)(struct adapter *padapter); 168 166 169 167 s32 (*init_xmit_priv)(struct adapter *padapter);
+1
drivers/staging/rtl8723bs/include/rtl8723b_xmit.h
··· 406 406 void rtl8723b_fill_fake_txdesc(struct adapter *padapter, u8 *pDesc, u32 BufferLen, u8 IsPsPoll, u8 IsBTQosNull, u8 bDataFrame); 407 407 408 408 u32 rtl8723bs_hal_init(struct adapter *padapter); 409 + u32 rtl8723bs_hal_deinit(struct adapter *padapter); 409 410 s32 rtl8723bs_init_xmit_priv(struct adapter *padapter); 410 411 void rtl8723bs_free_xmit_priv(struct adapter *padapter); 411 412 s32 rtl8723bs_hal_xmit(struct adapter *padapter, struct xmit_frame *pxmitframe);