Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
tjh.dev
kernel
os
linux
irqchip/csky-mpintc: Fixup mask/unmask implementation
The mask/unmask must be implemented, and enable/disable supplement
them if the HW requires something different at startup time. When
irq source is disabled by mask, mpintc could complete irq normally.
So drop enable/disable if favour of mask/unmask.
Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20211101134534.3804542-1-guoren@kernel.org
authored by Guo Ren and committed by Marc Zyngier 1cbb418b debe436e
+4
-4
drivers/irqchip/irq-csky-mpintc.c
+4
-4
drivers/irqchip/irq-csky-mpintc.c
···
78
78
readl_relaxed(reg_base + INTCL_RDYIR));
79
79
}
80
80
81
-
static void csky_mpintc_enable(struct irq_data *d)
81
+
static void csky_mpintc_unmask(struct irq_data *d)
82
82
{
83
83
void __iomem *reg_base = this_cpu_read(intcl_reg);
84
84
···
87
87
writel_relaxed(d->hwirq, reg_base + INTCL_SENR);
88
88
}
89
89
90
-
static void csky_mpintc_disable(struct irq_data *d)
90
+
static void csky_mpintc_mask(struct irq_data *d)
91
91
{
92
92
void __iomem *reg_base = this_cpu_read(intcl_reg);
93
93
···
164
164
static struct irq_chip csky_irq_chip = {
165
165
.name = "C-SKY SMP Intc",
166
166
.irq_eoi = csky_mpintc_eoi,
167
-
.irq_enable = csky_mpintc_enable,
168
-
.irq_disable = csky_mpintc_disable,
167
+
.irq_unmask = csky_mpintc_unmask,
168
+
.irq_mask = csky_mpintc_mask,
169
169
.irq_set_type = csky_mpintc_set_type,
170
170
#ifdef CONFIG_SMP
171
171
.irq_set_affinity = csky_irq_set_affinity,