Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/xe: Add helper to calculate adjusted register offset

Our MMIO accessing functions automatically adjust addresses for the
media registers based on mmio.adj_limit and mmio.adj_offset logic.
Move it to the separate helper to avoid code duplication and to
allow using it by the upcoming changes to PF driver code.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Piotr Piórkowski <piotr.piorkowski@intel.com>
Reviewed-by: Piotr Piórkowski <piotr.piorkowski@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240423180436.2089-3-michal.wajdeczko@intel.com

+22 -23
+15 -23
drivers/gpu/drm/xe/xe_mmio.c
··· 423 423 u8 xe_mmio_read8(struct xe_gt *gt, struct xe_reg reg) 424 424 { 425 425 struct xe_tile *tile = gt_to_tile(gt); 426 + u32 addr = xe_mmio_adjusted_addr(gt, reg.addr); 426 427 427 - if (reg.addr < gt->mmio.adj_limit) 428 - reg.addr += gt->mmio.adj_offset; 429 - 430 - return readb((reg.ext ? tile->mmio_ext.regs : tile->mmio.regs) + reg.addr); 428 + return readb((reg.ext ? tile->mmio_ext.regs : tile->mmio.regs) + addr); 431 429 } 432 430 433 431 u16 xe_mmio_read16(struct xe_gt *gt, struct xe_reg reg) 434 432 { 435 433 struct xe_tile *tile = gt_to_tile(gt); 434 + u32 addr = xe_mmio_adjusted_addr(gt, reg.addr); 436 435 437 - if (reg.addr < gt->mmio.adj_limit) 438 - reg.addr += gt->mmio.adj_offset; 439 - 440 - return readw((reg.ext ? tile->mmio_ext.regs : tile->mmio.regs) + reg.addr); 436 + return readw((reg.ext ? tile->mmio_ext.regs : tile->mmio.regs) + addr); 441 437 } 442 438 443 439 void xe_mmio_write32(struct xe_gt *gt, struct xe_reg reg, u32 val) 444 440 { 445 441 struct xe_tile *tile = gt_to_tile(gt); 442 + u32 addr = xe_mmio_adjusted_addr(gt, reg.addr); 446 443 447 - if (reg.addr < gt->mmio.adj_limit) 448 - reg.addr += gt->mmio.adj_offset; 449 - 450 - writel(val, (reg.ext ? tile->mmio_ext.regs : tile->mmio.regs) + reg.addr); 444 + writel(val, (reg.ext ? tile->mmio_ext.regs : tile->mmio.regs) + addr); 451 445 } 452 446 453 447 u32 xe_mmio_read32(struct xe_gt *gt, struct xe_reg reg) 454 448 { 455 449 struct xe_tile *tile = gt_to_tile(gt); 450 + u32 addr = xe_mmio_adjusted_addr(gt, reg.addr); 456 451 457 - if (reg.addr < gt->mmio.adj_limit) 458 - reg.addr += gt->mmio.adj_offset; 459 - 460 - return readl((reg.ext ? tile->mmio_ext.regs : tile->mmio.regs) + reg.addr); 452 + return readl((reg.ext ? tile->mmio_ext.regs : tile->mmio.regs) + addr); 461 453 } 462 454 463 455 u32 xe_mmio_rmw32(struct xe_gt *gt, struct xe_reg reg, u32 clr, u32 set) ··· 478 486 const struct xe_mmio_range *range, 479 487 struct xe_reg reg) 480 488 { 481 - if (reg.addr < gt->mmio.adj_limit) 482 - reg.addr += gt->mmio.adj_offset; 489 + u32 addr = xe_mmio_adjusted_addr(gt, reg.addr); 483 490 484 - return range && reg.addr >= range->start && reg.addr <= range->end; 491 + return range && addr >= range->start && addr <= range->end; 485 492 } 486 493 487 494 /** ··· 510 519 struct xe_reg reg_udw = { .addr = reg.addr + 0x4 }; 511 520 u32 ldw, udw, oldudw, retries; 512 521 513 - if (reg.addr < gt->mmio.adj_limit) { 514 - reg.addr += gt->mmio.adj_offset; 515 - reg_udw.addr += gt->mmio.adj_offset; 516 - } 522 + reg.addr = xe_mmio_adjusted_addr(gt, reg.addr); 523 + reg_udw.addr = xe_mmio_adjusted_addr(gt, reg_udw.addr); 524 + 525 + /* we shouldn't adjust just one register address */ 526 + xe_gt_assert(gt, reg_udw.addr == reg.addr + 0x4); 517 527 518 528 oldudw = xe_mmio_read32(gt, reg_udw); 519 529 for (retries = 5; retries; --retries) {
+7
drivers/gpu/drm/xe/xe_mmio.h
··· 36 36 int xe_mmio_wait32(struct xe_gt *gt, struct xe_reg reg, u32 mask, u32 val, u32 timeout_us, 37 37 u32 *out_val, bool atomic); 38 38 39 + static inline u32 xe_mmio_adjusted_addr(const struct xe_gt *gt, u32 addr) 40 + { 41 + if (addr < gt->mmio.adj_limit) 42 + addr += gt->mmio.adj_offset; 43 + return addr; 44 + } 45 + 39 46 #endif