Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[media] bdisp: prevent compiling on random arch

This driver requires support for DMA attrs function, and not
just DMA. Change the options accordingly to remove those errors:

/devel/v4l/to_next/drivers/media/platform/sti/bdisp/bdisp-hw.c: In function ‘bdisp_hw_free_nodes’:
/devel/v4l/to_next/drivers/media/platform/sti/bdisp/bdisp-hw.c:132:3: error: implicit declaration of function ‘dma_free_attrs’ [-Werror=implicit-function-declaration]
dma_free_attrs(ctx->bdisp_dev->dev,
^
/devel/v4l/to_next/drivers/media/platform/sti/bdisp/bdisp-hw.c: In function ‘bdisp_hw_alloc_nodes’:
/devel/v4l/to_next/drivers/media/platform/sti/bdisp/bdisp-hw.c:157:9: error: implicit declaration of function ‘dma_alloc_attrs’ [-Werror=implicit-function-declaration]
base = dma_alloc_attrs(dev, node_size * MAX_NB_NODE, &paddr,
^
/devel/v4l/to_next/drivers/media/platform/sti/bdisp/bdisp-hw.c:157:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
base = dma_alloc_attrs(dev, node_size * MAX_NB_NODE, &paddr,
^
/devel/v4l/to_next/drivers/media/platform/sti/bdisp/bdisp-hw.c: In function ‘bdisp_hw_alloc_filters’:
/devel/v4l/to_next/drivers/media/platform/sti/bdisp/bdisp-hw.c:219:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
base = dma_alloc_attrs(dev, size, &paddr, GFP_KERNEL | GFP_DMA, &attrs);

Also, get rid of bogus, unused and duplicated symbol declaration
for the config option done at bdisp/Kconfig.

Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

+1 -10
+1 -1
drivers/media/platform/Kconfig
··· 216 216 tristate "STMicroelectronics BDISP 2D blitter driver" 217 217 depends on VIDEO_DEV && VIDEO_V4L2 218 218 depends on ARCH_STI || COMPILE_TEST 219 - depends on HAS_DMA 219 + depends on HAVE_DMA_ATTRS 220 220 select VIDEOBUF2_DMA_CONTIG 221 221 select V4L2_MEM2MEM_DEV 222 222 help
-9
drivers/media/platform/sti/bdisp/Kconfig
··· 1 - config VIDEO_STI_BDISP 2 - tristate "STMicroelectronics BDISP 2D blitter driver" 3 - depends on VIDEO_DEV && VIDEO_V4L2 4 - select VIDEOBUF2_DMA_CONTIG 5 - select V4L2_MEM2MEM_DEV 6 - help 7 - This v4l2 mem2mem driver is a 2D blitter for STMicroelectronics SoC. 8 - To compile this driver as a module, choose M here: the module will 9 - be called bdisp.ko.