Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

usb: chipidea/ci_hdrc_msm: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart from
emitting a warning) and this typically results in resource leaks. To improve
here there is a quest to make the remove callback return void. In the first
step of this quest all drivers are converted to .remove_new() which already
returns void. Eventually after all drivers are converted, .remove_new() is
renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230517230239.187727-7-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Uwe Kleine-König and committed by
Greg Kroah-Hartman
1c74875c ad593ed6

+2 -4
+2 -4
drivers/usb/chipidea/ci_hdrc_msm.c
··· 274 274 return ret; 275 275 } 276 276 277 - static int ci_hdrc_msm_remove(struct platform_device *pdev) 277 + static void ci_hdrc_msm_remove(struct platform_device *pdev) 278 278 { 279 279 struct ci_hdrc_msm *ci = platform_get_drvdata(pdev); 280 280 ··· 282 282 ci_hdrc_remove_device(ci->ci); 283 283 clk_disable_unprepare(ci->iface_clk); 284 284 clk_disable_unprepare(ci->core_clk); 285 - 286 - return 0; 287 285 } 288 286 289 287 static const struct of_device_id msm_ci_dt_match[] = { ··· 292 294 293 295 static struct platform_driver ci_hdrc_msm_driver = { 294 296 .probe = ci_hdrc_msm_probe, 295 - .remove = ci_hdrc_msm_remove, 297 + .remove_new = ci_hdrc_msm_remove, 296 298 .driver = { 297 299 .name = "msm_hsusb", 298 300 .of_match_table = msm_ci_dt_match,