Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

atm: iphase: fix possible use-after-free in ia_module_exit()

This module's remove path calls del_timer(). However, that function
does not wait until the timer handler finishes. This means that the
timer handler may still be running after the driver's remove function
has finished, which would result in a use-after-free.

Fix by calling del_timer_sync(), which makes sure the timer handler
has finished, and unable to re-schedule itself.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Zou Wei and committed by
David S. Miller
1c72e6ab 3913ba73

+1 -1
+1 -1
drivers/atm/iphase.c
··· 3282 3282 { 3283 3283 pci_unregister_driver(&ia_driver); 3284 3284 3285 - del_timer(&ia_timer); 3285 + del_timer_sync(&ia_timer); 3286 3286 } 3287 3287 3288 3288 module_init(ia_module_init);