Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

dm: avoid useless 'else' after 'break' or return'

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>

authored by

Heinz Mauelshagen and committed by
Mike Snitzer
1c3fe2fa ae99111e

+38 -38
+4 -4
drivers/md/dm-stripe.c
··· 259 259 sc->stripe[target_stripe].physical_start; 260 260 bio->bi_iter.bi_size = to_bytes(end - begin); 261 261 return DM_MAPIO_REMAPPED; 262 - } else { 263 - /* The range doesn't map to the target stripe */ 264 - bio_endio(bio); 265 - return DM_MAPIO_SUBMITTED; 266 262 } 263 + 264 + /* The range doesn't map to the target stripe */ 265 + bio_endio(bio); 266 + return DM_MAPIO_SUBMITTED; 267 267 } 268 268 269 269 static int stripe_map(struct dm_target *ti, struct bio *bio)
+2 -2
drivers/md/dm-thin-metadata.c
··· 1612 1612 if (r) { 1613 1613 if (r == -ENODATA) 1614 1614 break; 1615 - else 1616 - return r; 1615 + 1616 + return r; 1617 1617 } 1618 1618 1619 1619 if ((lookup.block != pool_end) ||
+17 -16
drivers/md/dm-verity-target.c
··· 110 110 sg_init_one(&sg, data, len); 111 111 ahash_request_set_crypt(req, &sg, NULL, len); 112 112 return crypto_wait_req(crypto_ahash_update(req), wait); 113 - } else { 114 - do { 115 - int r; 116 - size_t this_step = min_t(size_t, len, PAGE_SIZE - offset_in_page(data)); 117 - 118 - flush_kernel_vmap_range((void *)data, this_step); 119 - sg_init_table(&sg, 1); 120 - sg_set_page(&sg, vmalloc_to_page(data), this_step, offset_in_page(data)); 121 - ahash_request_set_crypt(req, &sg, NULL, this_step); 122 - r = crypto_wait_req(crypto_ahash_update(req), wait); 123 - if (unlikely(r)) 124 - return r; 125 - data += this_step; 126 - len -= this_step; 127 - } while (len); 128 - return 0; 129 113 } 114 + 115 + do { 116 + int r; 117 + size_t this_step = min_t(size_t, len, PAGE_SIZE - offset_in_page(data)); 118 + 119 + flush_kernel_vmap_range((void *)data, this_step); 120 + sg_init_table(&sg, 1); 121 + sg_set_page(&sg, vmalloc_to_page(data), this_step, offset_in_page(data)); 122 + ahash_request_set_crypt(req, &sg, NULL, this_step); 123 + r = crypto_wait_req(crypto_ahash_update(req), wait); 124 + if (unlikely(r)) 125 + return r; 126 + data += this_step; 127 + len -= this_step; 128 + } while (len); 129 + 130 + return 0; 130 131 } 131 132 132 133 /*
+8 -8
drivers/md/dm-writecache.c
··· 623 623 if (unlikely(!node)) { 624 624 if (!(flags & WFE_RETURN_FOLLOWING)) 625 625 return NULL; 626 - if (read_original_sector(wc, e) >= block) { 626 + if (read_original_sector(wc, e) >= block) 627 627 return e; 628 - } else { 629 - node = rb_next(&e->rb_node); 630 - if (unlikely(!node)) 631 - return NULL; 632 - e = container_of(node, struct wc_entry, rb_node); 633 - return e; 634 - } 628 + 629 + node = rb_next(&e->rb_node); 630 + if (unlikely(!node)) 631 + return NULL; 632 + 633 + e = container_of(node, struct wc_entry, rb_node); 634 + return e; 635 635 } 636 636 } 637 637
+2 -2
drivers/md/persistent-data/dm-btree.c
··· 1352 1352 i = le32_to_cpu(ro_node(s)->header.nr_entries); 1353 1353 if (!i) 1354 1354 return -ENODATA; 1355 - else 1356 - i--; 1355 + 1356 + i--; 1357 1357 1358 1358 if (find_highest) 1359 1359 *result_key = le64_to_cpu(ro_node(s)->keys[i]);
+5 -6
drivers/md/persistent-data/dm-space-map-common.c
··· 793 793 rc = le32_to_cpu(*v_ptr); 794 794 *old_rc = rc; 795 795 796 - if (rc == 3) { 796 + if (rc == 3) 797 797 return __sm_ll_del_overflow(ll, b, ic); 798 - } else { 799 - rc--; 800 - *v_ptr = cpu_to_le32(rc); 801 - return 0; 802 - } 798 + 799 + rc--; 800 + *v_ptr = cpu_to_le32(rc); 801 + return 0; 803 802 } 804 803 805 804 static int sm_ll_dec_overflow(struct ll_disk *ll, dm_block_t b,