Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

usb: image: mdc800: kill download URB on timeout

mdc800_device_read() submits download_urb and waits for completion.
If the timeout fires and the device has not responded, the function
returns without killing the URB, leaving it active.

A subsequent read() resubmits the same URB while it is still
in-flight, triggering the WARN in usb_submit_urb():

"URB submitted while active"

Check the return value of wait_event_timeout() and kill the URB if
it indicates timeout, ensuring the URB is complete before its status
is inspected or the URB is resubmitted.

Similar to
- commit 372c93131998 ("USB: yurex: fix control-URB timeout handling")
- commit b98d5000c505 ("media: rc: iguanair: handle timeouts")

Signed-off-by: Ziyi Guo <n7l8m4@u.northwestern.edu>
Cc: stable <stable@kernel.org>
Link: https://patch.msgid.link/20260209151937.2247202-1-n7l8m4@u.northwestern.edu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Ziyi Guo and committed by
Greg Kroah-Hartman
1be3b77d 2d6d260e

+3 -1
+3 -1
drivers/usb/image/mdc800.c
··· 730 730 mutex_unlock(&mdc800->io_lock); 731 731 return len-left; 732 732 } 733 - wait_event_timeout(mdc800->download_wait, 733 + retval = wait_event_timeout(mdc800->download_wait, 734 734 mdc800->downloaded, 735 735 msecs_to_jiffies(TO_DOWNLOAD_GET_READY)); 736 + if (!retval) 737 + usb_kill_urb(mdc800->download_urb); 736 738 mdc800->downloaded = 0; 737 739 if (mdc800->download_urb->status != 0) 738 740 {