Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[patch 05/14] hpfs: dont call permission()

hpfs_unlink() calls permission() prior to truncating the file. HPFS
doesn't define a .permission method, so replace with explicit call to
generic_permission().

This is equivalent, except that devcgroup_inode_permission() and
security_inode_permission() are not called.

The truncation is just an implementation detail of the unlink, so
these security checks are unnecessary.

I suspect that even calling generic_permission() is unnecessary, since
we shouldn't mind if the file isn't writable. But I leave that to the
maintainer to decide.

Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
CC: Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>

authored by

Miklos Szeredi and committed by
Al Viro
1bd5191d 9043476f

+1 -1
+1 -1
fs/hpfs/namei.c
··· 415 415 d_drop(dentry); 416 416 spin_lock(&dentry->d_lock); 417 417 if (atomic_read(&dentry->d_count) > 1 || 418 - permission(inode, MAY_WRITE, NULL) || 418 + generic_permission(inode, MAY_WRITE, NULL) || 419 419 !S_ISREG(inode->i_mode) || 420 420 get_write_access(inode)) { 421 421 spin_unlock(&dentry->d_lock);