[IrDA]: Fix RCU lock pairing on error path

irlan_client_discovery_indication calls rcu_read_lock and rcu_read_unlock, but
returns without unlocking in an error case. Fix that by replacing the return
with a goto so that the rcu_read_unlock always gets executed.

Signed-off-by: Josh Triplett <josh@freedesktop.org>
Acked-by: Paul E. McKenney <paulmck@us.ibm.com>
Signed-off-by: Samuel Ortiz samuel@sortiz.org <>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by Josh Triplett and committed by David S. Miller 1bc17311 244055fd

+2 -1
+2 -1
net/irda/irlan/irlan_client.c
··· 173 173 rcu_read_lock(); 174 174 self = irlan_get_any(); 175 175 if (self) { 176 - IRDA_ASSERT(self->magic == IRLAN_MAGIC, return;); 176 + IRDA_ASSERT(self->magic == IRLAN_MAGIC, goto out;); 177 177 178 178 IRDA_DEBUG(1, "%s(), Found instance (%08x)!\n", __FUNCTION__ , 179 179 daddr); 180 180 181 181 irlan_client_wakeup(self, saddr, daddr); 182 182 } 183 + IRDA_ASSERT_LABEL(out:) 183 184 rcu_read_unlock(); 184 185 } 185 186