Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/bridge/lontium-lt9611uxc: fix get_edid return code

Return NULL pointer from get_edid() callback rather than ERR_PTR()
pointer, as DRM code does NULL checks rather than IS_ERR(). Also while
we are at it, return NULL if getting EDID timed out.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Fixes: 0cbbd5b1a012 ("drm: bridge: add support for lontium LT9611UXC bridge")
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210121233303.1221784-3-dmitry.baryshkov@linaro.org

authored by

Dmitry Baryshkov and committed by
Andrzej Hajda
1bb7ab40 053b1b28

+4 -1
+4 -1
drivers/gpu/drm/bridge/lontium-lt9611uxc.c
··· 505 505 ret = lt9611uxc_wait_for_edid(lt9611uxc); 506 506 if (ret < 0) { 507 507 dev_err(lt9611uxc->dev, "wait for EDID failed: %d\n", ret); 508 - return ERR_PTR(ret); 508 + return NULL; 509 + } else if (ret == 0) { 510 + dev_err(lt9611uxc->dev, "wait for EDID timeout\n"); 511 + return NULL; 509 512 } 510 513 511 514 return drm_do_get_edid(connector, lt9611uxc_get_edid_block, lt9611uxc);