Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

pcmcia: xxs1500_ss: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/09a89926787cb9f64caa73c510f04d9f04a5136f.1702051073.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Uwe Kleine-König and committed by
Greg Kroah-Hartman
1b775e61 c1991d49

+2 -4
+2 -4
drivers/pcmcia/xxs1500_ss.c
··· 301 301 return ret; 302 302 } 303 303 304 - static int xxs1500_pcmcia_remove(struct platform_device *pdev) 304 + static void xxs1500_pcmcia_remove(struct platform_device *pdev) 305 305 { 306 306 struct xxs1500_pcmcia_sock *sock = platform_get_drvdata(pdev); 307 307 ··· 309 309 free_irq(gpio_to_irq(GPIO_CDA), sock); 310 310 iounmap((void *)(sock->virt_io + (u32)mips_io_port_base)); 311 311 kfree(sock); 312 - 313 - return 0; 314 312 } 315 313 316 314 static struct platform_driver xxs1500_pcmcia_socket_driver = { ··· 316 318 .name = "xxs1500_pcmcia", 317 319 }, 318 320 .probe = xxs1500_pcmcia_probe, 319 - .remove = xxs1500_pcmcia_remove, 321 + .remove_new = xxs1500_pcmcia_remove, 320 322 }; 321 323 322 324 module_platform_driver(xxs1500_pcmcia_socket_driver);