platform/x86: dell-uart-backlight: fix serdev race

The dell_uart_bl_serdev_probe() function calls devm_serdev_device_open()
before setting the client ops via serdev_device_set_client_ops(). This
ordering can trigger a NULL pointer dereference in the serdev controller's
receive_buf handler, as it assumes serdev->ops is valid when
SERPORT_ACTIVE is set.

This is similar to the issue fixed in commit 5e700b384ec1
("platform/chrome: cros_ec_uart: properly fix race condition") where
devm_serdev_device_open() was called before fully initializing the
device.

Fix the race by ensuring client ops are set before enabling the port via
devm_serdev_device_open().

Note, serdev_device_set_baudrate() and serdev_device_set_flow_control()
calls should be after the devm_serdev_device_open() call.

Fixes: 484bae9e4d6a ("platform/x86: Add new Dell UART backlight driver")
Signed-off-by: Chenyuan Yang <chenyuan0y@gmail.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20250111180118.2274516-1-chenyuan0y@gmail.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

authored by Chenyuan Yang and committed by Ilpo Järvinen 1b2128aa 1d7461d0

Changed files
+3 -2
drivers
platform
+3 -2
drivers/platform/x86/dell/dell-uart-backlight.c
··· 283 283 init_waitqueue_head(&dell_bl->wait_queue); 284 284 dell_bl->dev = dev; 285 285 286 + serdev_device_set_drvdata(serdev, dell_bl); 287 + serdev_device_set_client_ops(serdev, &dell_uart_bl_serdev_ops); 288 + 286 289 ret = devm_serdev_device_open(dev, serdev); 287 290 if (ret) 288 291 return dev_err_probe(dev, ret, "opening UART device\n"); ··· 293 290 /* 9600 bps, no flow control, these are the default but set them to be sure */ 294 291 serdev_device_set_baudrate(serdev, 9600); 295 292 serdev_device_set_flow_control(serdev, false); 296 - serdev_device_set_drvdata(serdev, dell_bl); 297 - serdev_device_set_client_ops(serdev, &dell_uart_bl_serdev_ops); 298 293 299 294 get_version[0] = DELL_SOF(GET_CMD_LEN); 300 295 get_version[1] = CMD_GET_VERSION;