Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

spi: uniphier: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230303172041.2103336-84-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Uwe Kleine-König and committed by
Mark Brown
1b13d196 b082694f

+2 -4
+2 -4
drivers/spi/spi-uniphier.c
··· 775 775 return ret; 776 776 } 777 777 778 - static int uniphier_spi_remove(struct platform_device *pdev) 778 + static void uniphier_spi_remove(struct platform_device *pdev) 779 779 { 780 780 struct spi_master *master = platform_get_drvdata(pdev); 781 781 struct uniphier_spi_priv *priv = spi_master_get_devdata(master); ··· 786 786 dma_release_channel(master->dma_rx); 787 787 788 788 clk_disable_unprepare(priv->clk); 789 - 790 - return 0; 791 789 } 792 790 793 791 static const struct of_device_id uniphier_spi_match[] = { ··· 796 798 797 799 static struct platform_driver uniphier_spi_driver = { 798 800 .probe = uniphier_spi_probe, 799 - .remove = uniphier_spi_remove, 801 + .remove_new = uniphier_spi_remove, 800 802 .driver = { 801 803 .name = "uniphier-spi", 802 804 .of_match_table = uniphier_spi_match,