Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[SCSI] Make scsi_scan_host work for drivers which find their own targets

If a driver can find its own targets, it can now fill in scan_finished and
(optionally) scan_start in the scsi_host_template. Then, when it calls
scsi_scan_host(), it will be called back (from a thread if asynchronous
discovery is enabled), first to start the scan, and then at intervals to
check if the scan is completed.

Also make scsi_prep_async_scan and scsi_finish_async_scan static.

Signed-off-by: Matthew Wilcox <matthew@wil.cx>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>

authored by

Matthew Wilcox and committed by
James Bottomley
1aa8fab2 93b45af5

+38 -7
+20 -7
drivers/scsi/scsi_scan.c
··· 1642 1642 * that other asynchronous scans started after this one won't affect the 1643 1643 * ordering of the discovered devices. 1644 1644 */ 1645 - struct async_scan_data *scsi_prep_async_scan(struct Scsi_Host *shost) 1645 + static struct async_scan_data *scsi_prep_async_scan(struct Scsi_Host *shost) 1646 1646 { 1647 1647 struct async_scan_data *data; 1648 1648 ··· 1686 1686 * This function announces all the devices it has found to the rest 1687 1687 * of the system. 1688 1688 */ 1689 - void scsi_finish_async_scan(struct async_scan_data *data) 1689 + static void scsi_finish_async_scan(struct async_scan_data *data) 1690 1690 { 1691 1691 struct Scsi_Host *shost; 1692 1692 ··· 1719 1719 kfree(data); 1720 1720 } 1721 1721 1722 + static void do_scsi_scan_host(struct Scsi_Host *shost) 1723 + { 1724 + if (shost->hostt->scan_finished) { 1725 + unsigned long start = jiffies; 1726 + if (shost->hostt->scan_start) 1727 + shost->hostt->scan_start(shost); 1728 + 1729 + while (!shost->hostt->scan_finished(shost, jiffies - start)) 1730 + msleep(10); 1731 + } else { 1732 + scsi_scan_host_selected(shost, SCAN_WILD_CARD, SCAN_WILD_CARD, 1733 + SCAN_WILD_CARD, 0); 1734 + } 1735 + } 1736 + 1722 1737 static int do_scan_async(void *_data) 1723 1738 { 1724 1739 struct async_scan_data *data = _data; 1725 - scsi_scan_host_selected(data->shost, SCAN_WILD_CARD, SCAN_WILD_CARD, 1726 - SCAN_WILD_CARD, 0); 1727 - 1740 + do_scsi_scan_host(data->shost); 1728 1741 scsi_finish_async_scan(data); 1729 1742 return 0; 1730 1743 } ··· 1755 1742 1756 1743 data = scsi_prep_async_scan(shost); 1757 1744 if (!data) { 1758 - scsi_scan_host_selected(shost, SCAN_WILD_CARD, SCAN_WILD_CARD, 1759 - SCAN_WILD_CARD, 0); 1745 + do_scsi_scan_host(shost); 1760 1746 return; 1761 1747 } 1748 + 1762 1749 kthread_run(do_scan_async, data, "scsi_scan_%d", shost->host_no); 1763 1750 } 1764 1751 EXPORT_SYMBOL(scsi_scan_host);
+18
include/scsi/scsi_host.h
··· 241 241 void (* target_destroy)(struct scsi_target *); 242 242 243 243 /* 244 + * If a host has the ability to discover targets on its own instead 245 + * of scanning the entire bus, it can fill in this function and 246 + * call scsi_scan_host(). This function will be called periodically 247 + * until it returns 1 with the scsi_host and the elapsed time of 248 + * the scan in jiffies. 249 + * 250 + * Status: OPTIONAL 251 + */ 252 + int (* scan_finished)(struct Scsi_Host *, unsigned long); 253 + 254 + /* 255 + * If the host wants to be called before the scan starts, but 256 + * after the midlayer has set up ready for the scan, it can fill 257 + * in this function. 258 + */ 259 + void (* scan_start)(struct Scsi_Host *); 260 + 261 + /* 244 262 * fill in this function to allow the queue depth of this host 245 263 * to be changeable (on a per device basis). returns either 246 264 * the current queue depth setting (may be different from what