Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: pch_gbe: remove unneeded variable retval in __pch_gbe_suspend

Fix the following coccicheck warning:

./drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:2415:5-11: Unneeded variable: "retval". Return "0" on line 2435

Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
Link: https://lore.kernel.org/r/1604837580-12419-1-git-send-email-kaixuxia@tencent.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Kaixu Xia and committed by
Jakub Kicinski
1aa844b9 3ec94da9

+1 -2
+1 -2
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
··· 2412 2412 struct pch_gbe_adapter *adapter = netdev_priv(netdev); 2413 2413 struct pch_gbe_hw *hw = &adapter->hw; 2414 2414 u32 wufc = adapter->wake_up_evt; 2415 - int retval = 0; 2416 2415 2417 2416 netif_device_detach(netdev); 2418 2417 if (netif_running(netdev)) ··· 2431 2432 pch_gbe_mac_set_wol_event(hw, wufc); 2432 2433 pci_disable_device(pdev); 2433 2434 } 2434 - return retval; 2435 + return 0; 2435 2436 } 2436 2437 2437 2438 #ifdef CONFIG_PM