Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: mmc: siano: simplify module initialization

This driver's initialization functions do not perform any custom code,
except printing messages. Printing messages on modules
loading/unloading is discouraged because it pollutes the dmesg
regardless whether user actually has this device. Core kernel code
already gives tools to investigate whether module was loaded or not.

Drop the printing messages which allows to replace open-coded
module_sdio_driver().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

authored by

Krzysztof Kozlowski and committed by
Hans Verkuil
1a4a993c 53358137

+1 -24
+1 -24
drivers/media/mmc/siano/smssdio.c
··· 344 344 .probe = smssdio_probe, 345 345 .remove = smssdio_remove, 346 346 }; 347 - 348 - /*******************************************************************/ 349 - /* Module functions */ 350 - /*******************************************************************/ 351 - 352 - static int __init smssdio_module_init(void) 353 - { 354 - int ret = 0; 355 - 356 - printk(KERN_INFO "smssdio: Siano SMS1xxx SDIO driver\n"); 357 - printk(KERN_INFO "smssdio: Copyright Pierre Ossman\n"); 358 - 359 - ret = sdio_register_driver(&smssdio_driver); 360 - 361 - return ret; 362 - } 363 - 364 - static void __exit smssdio_module_exit(void) 365 - { 366 - sdio_unregister_driver(&smssdio_driver); 367 - } 368 - 369 - module_init(smssdio_module_init); 370 - module_exit(smssdio_module_exit); 347 + module_sdio_driver(smssdio_driver); 371 348 372 349 MODULE_DESCRIPTION("Siano SMS1xxx SDIO driver"); 373 350 MODULE_AUTHOR("Pierre Ossman");